Return-Path: X-Original-To: apmail-cordova-dev-archive@www.apache.org Delivered-To: apmail-cordova-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id EC93311796 for ; Fri, 1 Aug 2014 02:21:54 +0000 (UTC) Received: (qmail 62311 invoked by uid 500); 1 Aug 2014 02:21:54 -0000 Delivered-To: apmail-cordova-dev-archive@cordova.apache.org Received: (qmail 62264 invoked by uid 500); 1 Aug 2014 02:21:54 -0000 Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cordova.apache.org Delivered-To: mailing list dev@cordova.apache.org Received: (qmail 62252 invoked by uid 99); 1 Aug 2014 02:21:54 -0000 Received: from tyr.zones.apache.org (HELO tyr.zones.apache.org) (140.211.11.114) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 01 Aug 2014 02:21:54 +0000 Received: by tyr.zones.apache.org (Postfix, from userid 65534) id 159929BC222; Fri, 1 Aug 2014 02:21:54 +0000 (UTC) From: kamrik To: dev@cordova.apache.org Reply-To: dev@cordova.apache.org Message-ID: Subject: [GitHub] cordova-lib pull request: Add JSCS config file Content-Type: text/plain Date: Fri, 1 Aug 2014 02:21:54 +0000 (UTC) GitHub user kamrik opened a pull request: https://github.com/apache/cordova-lib/pull/69 Add JSCS config file Don't merge yet - feedback wanted. JSHint people want to focus on syntax linting and are dropping style oriented options. They recommend using JSCS (in addition to JSHint) for style: https://github.com/jshint/jshint/issues/1339 JSCS has recently added the options dropped from JSHint. https://github.com/mdevils/node-jscs/issues/102 This commit contains a JSCS config file with some basic settings that generate very few errors with the existing cordova-cli and lib code. Would be glad to get some feedback about this. My goal is to eventually run JSCS together with JSHint as part of `npm test`. The nice thing about JSCS is that style flame wars can be way more structured with it, as we can argue about very specific well named JSCS config options, or even vote on them :) I'm using it with SublimeLinter-jscs https://sublime.wbond.net/packages/SublimeLinter-jscs You can merge this pull request into a Git repository by running: $ git pull https://github.com/kamrik/cordova-lib jscs Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/69.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #69 ---- commit bad67bd12958d8ba7d32ffe41cdc81967bd17a15 Author: Mark Koudritsky Date: 2014-07-31T17:42:47Z Add JSCS config file Don't merge yet - feedback wanted. JSHint people want to focus on syntax linting and are dropping style oriented options. They recommends using JSCS (in addition to JSHint) for style: https://github.com/jshint/jshint/issues/1339 JSCS has recently added the options dropped from JSHint. https://github.com/mdevils/node-jscs/issues/102 This commit contains a JSCS config file with some basic settings that generate very few errors with the existing cordova-cli and lib code. Would be glad to get some feedback about this. My goal is to eventually run JSCS together with JSHint as part of `npm test`. The nice thing about JSCS is that style flame wars can be way more structured with it as we can argue about very specific well named JSCS config options :) I'm using it with SublimeLinter-jscs https://sublime.wbond.net/packages/SublimeLinter-jscs ---- --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---