cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From martincgg <...@git.apache.org>
Subject [GitHub] cordova-plugin-file pull request: [CB-7422][File Tests] Use proper...
Date Thu, 28 Aug 2014 22:33:35 GMT
GitHub user martincgg opened a pull request:

    https://github.com/apache/cordova-plugin-file/pull/77

    [CB-7422][File Tests] Use proper fileSystem to create fullPath

    The filesystem uses root filesystem (PERSISTENT) to compare with a TEMPORARY filesystem.
    This is wrong, if TEMPORARY, var 'temp_root' should be used to assign value to fullPath.
    Tested over android & WP8, everything OK.
    
    This wasn't caught before, because android : 
    fullPath is: /file, and (root.fullPath + file) returns ---> /file.
    although for Windows Phone: the fullPath provides the nativePath as /tmp//file, when it
tries to compare with (root.fullPath + file) gives //file. But tmp_root.fullPath provides
the right path: /tmp/ to compare with.
    
    Android it doesn't provide any different fullPath property if temporary or persistent,
the right path it's contained over the Native or Internal path.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/martincgg/cordova-plugin-file CB-7422

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-file/pull/77.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #77
    
----
commit 690cbdf3edf2daf273bd7d18ce51e0b9cc76b8c1
Author: Martin Gonzalez <martin.c.glez.glez@gmail.com>
Date:   2014-08-28T22:18:34Z

    [CB-7422][File Tests] Use proper fileSystem to create fullPath
    
    The filesystem uses root filesystem (PERSISTENT) to compare with a
    TEMPORARY filesystem.
    This is wrong, if TEMPORARY, temp_root, should be used to assign value
    to fullPath.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message