cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Menardi <...@git.apache.org>
Subject [GitHub] cordova-lib pull request: CB-7372 Remove use of path.join for mani...
Date Fri, 22 Aug 2014 22:20:32 GMT
GitHub user Menardi opened a pull request:

    https://github.com/apache/cordova-lib/pull/77

    CB-7372 Remove use of path.join for manifest.launch_path

    I was having issues on Windows when creating a new FirefoxOS project. A brand new project,
when added to the Firefox App Manager, gave an error: "Launch path has to be an absolute path
starting with '/': '\index.html'". The issue is the use of path.join to generate manifest.launch_path.
On Windows, this uses backslashes, which caused the issue. I have opted to simply use concatenation
instead.
    
    I have also fixed an issue where "cordova prepare firefoxos" would fail if there was no
<content> tag in the config.xml. If it is not present, we default to index.html.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Menardi/cordova-lib patch-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-lib/pull/77.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #77
    
----
commit d79f0c16e89a77e682b750e10c195e45bf1430c2
Author: Menardi <hello@gearoid.me>
Date:   2014-08-22T21:35:13Z

    Remove use of path.join for manifest.launch_path
    
    I was having issues on Windows when creating a new FirefoxOS project. A brand new project,
when added to the Firefox App Manager, gave an error: "Launch path has to be an absolute path
starting with '/': '\index.html'". The issue is the use of path.join to generate manifest.launch_path.
On Windows, this uses backslashes, which caused the issue. I have opted to simply use concatenation
instead.
    
    I have also fixed an issue where "cordova prepare firefoxos" would fail if there was no
<content> tag in the config.xml. If it is not present, we default to index.html.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message