cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From martincgg <...@git.apache.org>
Subject [GitHub] cordova-plugin-file pull request: [CB-7417][File tests] added prop...
Date Wed, 27 Aug 2014 22:24:38 GMT
GitHub user martincgg opened a pull request:

    https://github.com/apache/cordova-plugin-file/pull/72

    [CB-7417][File tests] added proper matcher to compare fullPath property

    Specs : 111, 112 & 121-124, were using [toBe, toEqual] to compare a Entry's fullPath
property.
    The right matcher to use is toCanonicallyMatch, that it makes a fair and right comparison
across platforms.
    
    In addition, special case to compare Windows Phone entries, was removed.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/martincgg/cordova-plugin-file CB-7417

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-file/pull/72.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #72
    
----
commit b15778749f7487cc4a8fb66c33a86a1a48594430
Author: Martin Gonzalez <martin.c.glez.glez@gmail.com>
Date:   2014-08-27T22:20:43Z

    [CB-7417][File tests] added proper matcher to compare fullPath property
    
    Specs : 111, 112 & 121-124, were using [toBe, toEqual] to compare a
    fullPath property from an Entry.
    The right matcher to use is toCanonicallyMatch, that it makes a fair and
    right comparison across platforms.
    
    In addition, special case to compare Windows Phone entries, was removed.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message