cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From martincgg <...@git.apache.org>
Subject [GitHub] cordova-wp8 pull request: [CB-7338]Remove unwanted slashes in URL,...
Date Tue, 19 Aug 2014 20:59:27 GMT
GitHub user martincgg opened a pull request:

    https://github.com/apache/cordova-wp8/pull/50

    [CB-7338]Remove unwanted slashes in URL, and handle Exceptions when a resource is not
found

    The URL result of a XHR request, at times contains some unwanted extra slashes, like:
'x-wmapp0: /www or //www'. that URL starting with those slashes, is not well processed by
the URI class, so it's required remove them when the 'basePath' is obtained.
    Added, regExp to the js script code to remove any ---->  ':/, ://, :///' , any slash
after 'x-wmapp0:', in that way the URI class it will be successfully resolved and provide
the file requested.
    Removing unwanted slashes after x-wmapp0 from the basePath, URI cannot process x-wmapp0:
/www or //www.
    
    Also added two try-catch statements, over the 'Browser.InvokeScript' statements, if those
are not present it throws: 'A first chance exception of type 'System.OutOfMemoryException'
occurred in Microsoft.Phone.Interop.ni.dll', stopping the application.
    The try-catch statement it would throw this trace when a requested resource is not available,
found or not well resolved by the URI class:
    
    ERROR: Exception in HandleCommand: System.OutOfMemoryException: Insufficient memory to
continue the execution of the program.
       at Microsoft.Phone.Controls.NativeMethods.ValidateHResult(Int32 hr)
       at Microsoft.Phone.Controls.WebBrowserInterop.InvokeScript(String scriptName, String[]
args)
       at Microsoft.Phone.Controls.WebBrowser.InvokeScript(String scriptName, String[] args)
       at WPCordovaClassLib.CordovaLib.XHRHelper.HandleCommand(String commandStr)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/martincgg/cordova-wp8 CB-7338

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-wp8/pull/50.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #50
    
----
commit 8829719bbbca1e92670f4576f7baa5e6e4701b9a
Author: Martin Gonzalez <martin.c.glez.glez@gmail.com>
Date:   2014-08-19T18:15:43Z

    Remove unwanted slashes and handle Exceptions

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message