cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From KiaFathi <...@git.apache.org>
Subject [GitHub] cordova-plugin-camera pull request: Update Camera.js
Date Tue, 05 Aug 2014 00:25:18 GMT
GitHub user KiaFathi opened a pull request:

    https://github.com/apache/cordova-plugin-camera/pull/41

    Update Camera.js

    Platform: iOS
    Plugin: org.apache.cordova.camera
    Hardware: iphone 5
    Strange behavior when selecting photos from library with camera.getPicture and cameraOptions
with sourceType of Camera.PictureSourceType.PHOTOLIBRARY.
    Some photos rotate in unintuitive ways. I found that defaulting
    
     correctOrientation to true in my cameraOptions argument fixed this problem.
    
    Screenshots: 
    Before:
    ![photo 1](https://cloud.githubusercontent.com/assets/7144417/3805452/c19d4d34-1c36-11e4-9b94-7548f6cd13af.PNG)
    
    After:
    ![photo 2](https://cloud.githubusercontent.com/assets/7144417/3805454/c96995ea-1c36-11e4-947c-3c85e70bf74f.PNG)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/KiaFathi/cordova-plugin-camera patch-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-camera/pull/41.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #41
    
----
commit f4e09841b8eb7950d23a6fefac0cdb409c45f6e3
Author: Kia Fathi <kiafathi@me.com>
Date:   2014-08-05T00:22:30Z

    Update Camera.js

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message