cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From KiaFathi <...@git.apache.org>
Subject [GitHub] cordova-plugin-camera pull request: Update Camera.js
Date Mon, 04 Aug 2014 23:58:04 GMT
GitHub user KiaFathi opened a pull request:

    https://github.com/apache/cordova-plugin-camera/pull/40

    Update Camera.js

    Platform: iOS
    Plugin: org.apache.cordova.camera
    Hardware: iphone 5
    Strange behavior when selecting photos from library with camera.getPicture and cameraOptions
with sourceType of Camera.PictureSourceType.PHOTOLIBRARY.
    Some photos rotate in unintuitive ways. I found that hardcoding correctOrientation to
true in my cameraOptions argument fixed this problem.
    
    Before: 
    ![unknown 1](https://cloud.githubusercontent.com/assets/7144417/3805247/fd4f87d8-1c32-11e4-96c0-ad0915061064.png)
    
    After Change:
    ![unknown](https://cloud.githubusercontent.com/assets/7144417/3805246/fd4105fa-1c32-11e4-941c-18fd9afb9b9a.png)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/KiaFathi/cordova-plugin-camera patch-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-camera/pull/40.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #40
    
----
commit 43eaf3ce8bdaeae8539b1e93a19e7e40df02ab42
Author: Kia Fathi <kiafathi@me.com>
Date:   2014-08-04T23:56:12Z

    Update Camera.js
    
    Platform: iOS
    Plugin: org.apache.cordova.camera
    Hardware: iphone 5
    Strange behavior when selecting photos from library with camera.getPicture and cameraOptions
with sourceType of Camera.PictureSourceType.PHOTOLIBRARY.
    Some photos rotate in unintuitive ways. I found that hardcoding correctOrientation to
true in my cameraOptions argument fixed this problem.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message