cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From optikalefx <...@git.apache.org>
Subject [GitHub] cordova-plugin-dialogs pull request: Progress dialogs should be ca...
Date Fri, 22 Aug 2014 14:48:53 GMT
GitHub user optikalefx opened a pull request:

    https://github.com/apache/cordova-plugin-dialogs/pull/28

    Progress dialogs should be cancellable outside the window

    This change makes progress dialogs modal. In a sense that they can't be cancelled from
an outside touch. This is expected behavior for a progress bar.  Too many user errors by mis-tapping
outside the progress and then having no clue what happened.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ConnectAi/cordova-plugin-dialogs master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-dialogs/pull/28.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #28
    
----
commit 51be8503bb1510ca151d7ee77a37ffde02bf6017
Author: Sean Clark <sean@connectai.com>
Date:   2014-08-22T14:46:57Z

    Progress dialogs should be cancellable outside the window

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message