cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From stacic <...@git.apache.org>
Subject [GitHub] cordova-plugin-vibration pull request: CB-7216 API audit for vibra...
Date Thu, 28 Aug 2014 17:46:11 GMT
GitHub user stacic opened a pull request:

    https://github.com/apache/cordova-plugin-vibration/pull/21

    CB-7216 API audit for vibration on wp8

    Added support for:
        - cancelVibration (including vibration with pattern)
        - vibrateWithPattern
        - truncation of vibration when argument is > 5seconds on wp (formerly exception
was thrown)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/stacic/cordova-plugin-vibration CB-7216

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-vibration/pull/21.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #21
    
----
commit faa3d626d8f941273b8edadeb48f7f30af198a53
Author: Staci Cooper <smcooper@us.ibm.com>
Date:   2014-07-29T15:08:33Z

    CB-6914 added cancelVibration for wp8

commit 7dd0e6610be372b076daf6f6c80f4ec3aa5e0df4
Author: Staci Cooper <smcooper@us.ibm.com>
Date:   2014-07-29T15:24:43Z

    CB-6916 added vibrateWithPattern for wp8
    
    Also change to cancelVibration to allow for canceling a pattern

commit 6899790d10a951a858dd1bb2df0df20d0e010d26
Author: Staci Cooper <smcooper@us.ibm.com>
Date:   2014-07-29T15:36:48Z

    CB-7218 truncate vibration to 5 secs for WP8
    
    wp8 throws an error if given timespan > 5 secs for vibration. It should
    truncate the vibration instead.

commit 463dbfa9c5f69dc2f1ec6c2b1a8c5b2664d051a1
Author: Staci Cooper <smcooper@us.ibm.com>
Date:   2014-08-25T16:03:26Z

    Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/cordova-plugin-vibration
into CB-7216

commit 6612805e61dba39ea638c6801ff4e11163fa0d70
Author: Staci Cooper <smcooper@us.ibm.com>
Date:   2014-08-28T17:42:06Z

    CB-7216 changed cancelWasCalled boolean
    
    - changed variable name
    - clear at the beginning of call to vibrateWithPattern

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message