cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From SayreBlades <...@git.apache.org>
Subject [GitHub] cordova-plugin-statusbar pull request: Bad default configuration f...
Date Wed, 13 Aug 2014 15:37:35 GMT
GitHub user SayreBlades opened a pull request:

    https://github.com/apache/cordova-plugin-statusbar/pull/13

    Bad default configuration for IOS

    This should not be a default ios setting:
    <preference name="StatusBarBackgroundColor" value="#000000" />
    It makes it impossible to unset the initial background color (for transparent backgrounds).
 Instead just have the default as no background color (which will effectively be transparent),
and then allow users to override that with a desired color.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/SayreBlades/cordova-plugin-statusbar patch-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-statusbar/pull/13.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #13
    
----
commit 34f308e4a1713cc637c5c294a5c727848134bc27
Author: SayreBlades <sayre.blades@gmail.com>
Date:   2014-08-13T15:37:11Z

    Bad default configuration for IOS
    
    This should not be a default ios setting:
    <preference name="StatusBarBackgroundColor" value="#000000" />
    It makes it impossible to unset the initial background color (for transparent backgrounds).
 Instead just have the default as no background color (which will effectively be transparent),
and then allow users to override that with a desired color.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message