cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From martincgg <...@git.apache.org>
Subject [GitHub] cordova-android pull request: [CB-7371] Fixed: app crash after pho...
Date Fri, 22 Aug 2014 18:21:20 GMT
GitHub user martincgg opened a pull request:

    https://github.com/apache/cordova-android/pull/115

    [CB-7371] Fixed: app crash after phone language change

    The main reason of this behavior is the config.xml, origin="*" tag, specifies access to
all kind of resources on the network and makes the whiteList object on the WhiteList class
a null object, indicating that when origin="*", there's no whiteList, all is allowed.
    
    When it tries to resume the application it checks:
    if (url.startsWith("file://") || url.startsWith("javascript:") || whitelist.isUrlWhiteListed(url))
    This condition passes and triggers the load for 'about:blank'
    The condition passes because, whitelist.isUrlWhiteListed(url) statement returns true.
     When the origin="*" is processed by the WhiteList class, it sets a null to the whiteList
object, which it should contain the access to resources allowed, however when whitelist.isUrlWhiteListed(url)
it returns a true if the whiteList object is null, therefore the condition passes and continues
to the loadurl method on webClient, stopping the application, because of the 'about:blank'
url.
    
    Adding another condition along with that statement for when whiteList = null, but url=
about:blank, in that way it won't be able to load the url.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/martincgg/cordova-android master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-android/pull/115.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #115
    
----
commit f9c23ec8711719db86843e944e7749e758b2a3f4
Author: Martin Gonzalez <martin.c.glez.glez@gmail.com>
Date:   2014-08-22T18:09:42Z

    CB-7371 Fixed: app crash after phone language change

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message