cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Steven Gill <stevengil...@gmail.com>
Subject Re: Remove VERSION file from repos
Date Thu, 14 Aug 2014 00:28:22 GMT
Using android's method of doing this doesn't seem so bad to me.

Version script has hard coded value that coho sets when doing a release.
Seems to be working fine as long as coho is used for releasing.

Thoughts?


On Wed, Aug 13, 2014 at 1:44 PM, Carlos Santana <csantana23@gmail.com>
wrote:

> I think having the ios platform scripts in nodejs have a side benefit of
> being able to create ios platform on Linux and Windows.
>
> IBM Worklight customers use this use case, where they create ios cordova
> app, and in Windows or Linux they use it for preview with MBS a tool
> similar to Ripple, and generate a zip with the xcode project, they can use
> on a Mac with XCode for final build.
>
> The use case is also similar to create an ios platform app and preview in
> App Harness like PhoneGap Developer.
>
> just my two cents.
>
>
>
> On Tue, Aug 12, 2014 at 4:46 PM, Shazron <shazron@gmail.com> wrote:
>
> > Believe me, I want to go all node -- but all in for all scripts --
> > which we don't have time to do yet (maybe 4.0?).
> > But seeing that it's just replacing the contents of the current bash
> > script with python code, it's the path of least resistance, and path
> > of least potential conflict imo. No one will notice.
> >
> >
> > On Tue, Aug 12, 2014 at 1:36 PM, Michal Mocny <mmocny@chromium.org>
> wrote:
> > > Shaz, that's technically true, but how many users actually use that
> path
> > > these days?
> > >
> > > I thought the last stats overwhelmingly suggest our users are drinking
> > the
> > > kool-aid and using cli, node, etc.
> > >
> > >
> > > On Tue, Aug 12, 2014 at 4:19 PM, Shazron <shazron@gmail.com> wrote:
> > >
> > >> Not if they are installed manually. It's not worth having some
> > >> dependency just to read a version, that's nuts.
> > >>
> > >> On Tue, Aug 12, 2014 at 1:15 PM, Jesse <purplecabbage@gmail.com>
> wrote:
> > >> > the non-cordova cli path depends on node to install/uninstall
> plugins
> > >> >
> > >> > @purplecabbage
> > >> > risingj.com
> > >> >
> > >> >
> > >> > On Tue, Aug 12, 2014 at 1:08 PM, Shazron <shazron@gmail.com>
wrote:
> > >> >
> > >> >> Of course I considered nodejs, but no, this is for the non-cordova
> > CLI
> > >> >> path, which does not need another dependency.
> > >> >>
> > >> >> On Tue, Aug 12, 2014 at 11:52 AM, Jesse <purplecabbage@gmail.com>
> > >> wrote:
> > >> >> > Yeah, if you are going to replace bash, replace it with nodejs!
> > >> >> >
> > >> >> >
> > >> >> > @purplecabbage
> > >> >> > risingj.com
> > >> >> >
> > >> >> >
> > >> >> > On Tue, Aug 12, 2014 at 11:48 AM, Myles Borins <myles@famo.us>
> > wrote:
> > >> >> >
> > >> >> >> Have you considered writing a small node script to pass
the
> json?
> > >> This
> > >> >> >> would make it as simple as requiring in the package json
an
> piping
> > >> the
> > >> >> >> relevant info to stdout
> > >> >> >> On Aug 12, 2014 11:47 AM, "Shazron" <shazron@gmail.com>
wrote:
> > >> >> >>
> > >> >> >> > Yeah I value life and my sanity - I'll probably
replace the
> bash
> > >> >> >> > script with python
> > >> >> >> >
> > >> >> >> > On Tue, Aug 12, 2014 at 11:40 AM, Lorin Beer <
> > lorin.beer@gmail.com
> > >> >
> > >> >> >> wrote:
> > >> >> >> > > one source for version information is better
> > >> >> >> > >
> > >> >> >> > > although parsing json with bash scripts seems
janky
> > >> >> >> > >
> > >> >> >> > >
> > >> >> >> > > On Tue, Aug 12, 2014 at 11:31 AM, Jesse <
> > purplecabbage@gmail.com
> > >> >
> > >> >> >> wrote:
> > >> >> >> > >
> > >> >> >> > >> I think it still needs to exist in an output
project ...
> > which
> > >> is
> > >> >> not
> > >> >> >> > >> (yet?) an npm project, and so does not
have a package.json.
> > >> >> >> > >>
> > >> >> >> > >> The individual platform repos can get rid
of it, they will
> > just
> > >> >> need
> > >> >> >> to
> > >> >> >> > >> modify the way they `create` new projects
to read the value
> > from
> > >> >> >> > >> package.json and output it to NewProject/VERSION
> > >> >> >> > >>
> > >> >> >> > >>
> > >> >> >> > >>
> > >> >> >> > >>
> > >> >> >> > >> @purplecabbage
> > >> >> >> > >> risingj.com
> > >> >> >> > >>
> > >> >> >> > >>
> > >> >> >> > >> On Tue, Aug 12, 2014 at 11:25 AM, Shazron
<
> shazron@gmail.com
> > >
> > >> >> wrote:
> > >> >> >> > >>
> > >> >> >> > >> > For iOS, the only file I can see that
depends on this is:
> > >> >> >> > >> >
> > >> >> >> > >> > 1.
> > >> >> >> > >> >
> > >> >> >> > >>
> > >> >> >> >
> > >> >> >>
> > >> >>
> > >>
> >
> https://github.com/apache/cordova-ios/blob/master/bin/templates/scripts/cordova/version
> > >> >> >> > >> >
> > >> >> >> > >> > Not sure of the alternative.
> > >> >> >> > >> >
> > >> >> >> > >> > This references it but can be removed:
> > >> >> >> > >> >
> > https://github.com/apache/cordova-ios/blob/master/bin/create
> > >> >> >> > >> >
> > >> >> >> > >> >
> > >> >> >> > >> > On Tue, Aug 12, 2014 at 11:19 AM,
Steven Gill <
> > >> >> >> stevengill97@gmail.com
> > >> >> >> > >
> > >> >> >> > >> > wrote:
> > >> >> >> > >> > > Most of our repos have a package.json.
It keeps track
> of
> > >> >> >> versions. I
> > >> >> >> > >> > think
> > >> >> >> > >> > > we should work towards removing
the VERSION files from
> > the
> > >> >> repos
> > >> >> >> we
> > >> >> >> > >> can.
> > >> >> >> > >> > >
> > >> >> >> > >> > > Thoughts?
> > >> >> >> > >> > >
> > >> >> >> > >> > > This would require some changes
to coho so it doesn't
> > try to
> > >> >> >> update
> > >> >> >> > the
> > >> >> >> > >> > > version file when doing releases.
> > >> >> >> > >> >
> > >> >> >> > >>
> > >> >> >> >
> > >> >> >>
> > >> >>
> > >>
> >
>
>
>
> --
> Carlos Santana
> <csantana23@gmail.com>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message