cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michal Mocny <mmo...@chromium.org>
Subject Re: Remove VERSION file from repos
Date Tue, 12 Aug 2014 19:00:56 GMT
..re reading your email, I think thats exactly what you mean and also
suggested the same solution :P  alrighty!


On Tue, Aug 12, 2014 at 3:00 PM, Michal Mocny <mmocny@chromium.org> wrote:

> Jesse what did you mean about output projects and package.json?
>
> Do you mean the result of running cordova create / ./create script?  If
> the intention is to know what version of the platform was used to create
> the project, then we can either copy the source package.json to the root of
> the platform files, or just continue to create a VERSION file in the output
> of the create script for now.
>
> -Michal
>
>
>
> On Tue, Aug 12, 2014 at 2:52 PM, Jesse <purplecabbage@gmail.com> wrote:
>
>> Yeah, if you are going to replace bash, replace it with nodejs!
>>
>>
>> @purplecabbage
>> risingj.com
>>
>>
>> On Tue, Aug 12, 2014 at 11:48 AM, Myles Borins <myles@famo.us> wrote:
>>
>> > Have you considered writing a small node script to pass the json? This
>> > would make it as simple as requiring in the package json an piping the
>> > relevant info to stdout
>> > On Aug 12, 2014 11:47 AM, "Shazron" <shazron@gmail.com> wrote:
>> >
>> > > Yeah I value life and my sanity - I'll probably replace the bash
>> > > script with python
>> > >
>> > > On Tue, Aug 12, 2014 at 11:40 AM, Lorin Beer <lorin.beer@gmail.com>
>> > wrote:
>> > > > one source for version information is better
>> > > >
>> > > > although parsing json with bash scripts seems janky
>> > > >
>> > > >
>> > > > On Tue, Aug 12, 2014 at 11:31 AM, Jesse <purplecabbage@gmail.com>
>> > wrote:
>> > > >
>> > > >> I think it still needs to exist in an output project ... which
is
>> not
>> > > >> (yet?) an npm project, and so does not have a package.json.
>> > > >>
>> > > >> The individual platform repos can get rid of it, they will just
>> need
>> > to
>> > > >> modify the way they `create` new projects to read the value from
>> > > >> package.json and output it to NewProject/VERSION
>> > > >>
>> > > >>
>> > > >>
>> > > >>
>> > > >> @purplecabbage
>> > > >> risingj.com
>> > > >>
>> > > >>
>> > > >> On Tue, Aug 12, 2014 at 11:25 AM, Shazron <shazron@gmail.com>
>> wrote:
>> > > >>
>> > > >> > For iOS, the only file I can see that depends on this is:
>> > > >> >
>> > > >> > 1.
>> > > >> >
>> > > >>
>> > >
>> >
>> https://github.com/apache/cordova-ios/blob/master/bin/templates/scripts/cordova/version
>> > > >> >
>> > > >> > Not sure of the alternative.
>> > > >> >
>> > > >> > This references it but can be removed:
>> > > >> > https://github.com/apache/cordova-ios/blob/master/bin/create
>> > > >> >
>> > > >> >
>> > > >> > On Tue, Aug 12, 2014 at 11:19 AM, Steven Gill <
>> > stevengill97@gmail.com
>> > > >
>> > > >> > wrote:
>> > > >> > > Most of our repos have a package.json. It keeps track
of
>> > versions. I
>> > > >> > think
>> > > >> > > we should work towards removing the VERSION files from
the
>> repos
>> > we
>> > > >> can.
>> > > >> > >
>> > > >> > > Thoughts?
>> > > >> > >
>> > > >> > > This would require some changes to coho so it doesn't
try to
>> > update
>> > > the
>> > > >> > > version file when doing releases.
>> > > >> >
>> > > >>
>> > >
>> >
>>
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message