cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From purplecabbage <purplecabb...@gmail.com>
Subject Re: [GitHub] cordova-plugin-contacts pull request: Removed [optional] tag from ...
Date Sat, 02 Aug 2014 05:22:15 GMT
We don't need an cla for a 1 line documentation fix. 
Ultimately this is a defect in the plugin, and should be fixed. Documenting the quirk helps
in the meantime, until it is fixed for Android and ios. 

> On Aug 1, 2014, at 2:22 PM, lorinbeer <git@git.apache.org> wrote:
> 
> Github user lorinbeer commented on the pull request:
> 
>    https://github.com/apache/cordova-plugin-contacts/pull/37#issuecomment-50936354
> 
>    Hi @sgrebnov,
> 
>    omitting contactFindOptions results in a errorJSON return message on Android, and
I believe was replicated on iOS. Documenting the actual behavior of the plugin is essential,
and this issue has caused considerable confusion to using the contacts plugin.
> 
>    Thanks for the pull request Sebastian, we'll pull it in as soon as your CLA is recognized
by the Apache Secretary. @sgrebnov and myself may have suggestions in how to document the
issue (which can be accomplished by adding commits to the origin branch of the pull request)
depending on whether it is system wide, platform specific, deviation from spec, etc.
> 
> 
> 
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---

Mime
View raw message