cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pmuellr <>
Subject [GitHub] cordova-weinre pull request: Fix critical error in target device j...
Date Fri, 29 Aug 2014 22:06:11 GMT
Github user pmuellr commented on the pull request:
    pospi - thx for the PR.   Can you [open a bug](!init.jspa?pid=12312420&components=12316604&priority=3&issuetype=1)
so we can track this?
    I guess this fix looks ok, but is a bit worrisome.  Is the problem that the readystatechange
handler is not passed an event on some platform, or that the event that it's passed doesn't
have the xhr as the event target?
    I assume the original code worked on *some* platform(s).
    Also worried about about requiring function.bind(); perhaps we should "bind by hand" with
an additional function with the `this` in a closure?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message