cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jsoref <...@git.apache.org>
Subject [GitHub] cordova-lib pull request: CB-7336 Fix cordova platform add blackbe...
Date Wed, 20 Aug 2014 14:56:21 GMT
Github user jsoref commented on the pull request:

    https://github.com/apache/cordova-lib/pull/75#issuecomment-52789928
  
    re: renaming blackberry10 -> blackberry, that's something that BlackBerry (the entity)
could consider. I'm not willing to do it alone. I'm also unsure how good the upgrade path
is for that. I haven't tested (and given that there's clearly insufficient basic regression
testing, I'm not in a hurry to test this).
    
    It's certainly something that could be considered before a "4.0" release. @bryanhiggins?
    
    wrt bundling node_modules, I don't have the keys, so I'm not in a position to do that.
In my naive testing of this code w/ android and iOS, nothing exploded w/ this code,...
    
    As for bundledDependencies, that leads me to npm/npm#4210. I'm really not particularly
excited about implementing core features of npm, nor trying to investigate just how broken
some basic bits of package.json are.
    
    For this bug, I just want blackberry10 to work when someone releases cordova-lib 3.6,
which is not the case if it were released today.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message