cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kamrik <...@git.apache.org>
Subject [GitHub] cordova-lib pull request: CB-7336 Fix cordova platform add blackbe...
Date Tue, 19 Aug 2014 22:10:36 GMT
Github user kamrik commented on the pull request:

    https://github.com/apache/cordova-lib/pull/75#issuecomment-52706725
  
    Running npm install inside the platforms might result in some unexpected things. For example
in iOS, the node modules dir is bundles under bin/ rather as a sibling of package.json (no
idea why, and how/if they will interact).
    
    Should we just bundle node_modules with the blackberry npm package?
    
    Bundling node_modules with an npm package is not an uncommon practice. Also check npm's
bundledDependencies prop for package.json.
    
    While we are here: is there a good reason for keeping the blackberry10 name rather than
blackberry? We could leave blackberry10 as an alias translated to blackberry by the cli on
an early stage (like win variants are now) for backwards compatibility. Less complexity to
deal with later.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message