cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jsoref <...@git.apache.org>
Subject [GitHub] cordova-plugin-camera pull request: ubuntu: use application direct...
Date Wed, 13 Aug 2014 17:14:45 GMT
Github user jsoref commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-camera/pull/25#discussion_r16189883
  
    --- Diff: src/ubuntu/camera.h ---
    @@ -54,6 +54,16 @@ public slots:
     
         void onImageSaved(QString path);
     
    +    QString generateLocation(const QString &extension) {
    +        int i = 1;
    +        for (;;++i) {
    --- End diff --
    
    this should have a way to fail, otherwise it's a genuine infinite loop, which would be
bad.
    one approach is to fail w/ `i < 1`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message