cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jsoref <...@git.apache.org>
Subject [GitHub] cordova-plugin-camera pull request: ubuntu: use application direct...
Date Wed, 13 Aug 2014 17:13:26 GMT
Github user jsoref commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-camera/pull/25#discussion_r16189800
  
    --- Diff: src/ubuntu/camera.cpp ---
    @@ -136,7 +133,7 @@ void Camera::takePicture(int scId, int ecId, int quality, int destinationType,
i
     }
     
     void Camera::cancel() {
    -    m_cordova->execQML("CordovaWrapper.object.destroy()");
    +    m_cordova->execQML("CordovaWrapper.global.cameraPluginWidget.destroy()");
    --- End diff --
    
    this is the second instance of `CordovaWrapper.global.cameraPluginWidget`,
    it seems like you should use a `#define` and use pasting (`##` if necessary) instead...
    it also seems like you'd want this string to be at the top next to `code` so that it's
easier to read the related blobs of executable QML together w/ their collective context...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message