cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jsoref <...@git.apache.org>
Subject [GitHub] cordova-plugin-contacts pull request: [CB-7131] Check for profile ...
Date Wed, 13 Aug 2014 14:52:09 GMT
Github user jsoref commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-contacts/pull/39#discussion_r16179759
  
    --- Diff: src/android/ContactAccessorSdk5.java ---
    @@ -436,7 +436,10 @@ else if (mimetype.equals(ContactsContract.CommonDataKinds.Event.CONTENT_ITEM_TYP
                         }
                         else if (mimetype.equals(ContactsContract.CommonDataKinds.Photo.CONTENT_ITEM_TYPE)
                                 && isRequired("photos", populate)) {
    -                        photos.put(photoQuery(c, contactId));
    +                        JSONObject photo = photoQuery(c, contactId);
    +                        if (photo != null) {
    +                          photos.put(photo);
    --- End diff --
    
    this is probably under indented (2 space instead of 4 space)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message