cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jsoref <...@git.apache.org>
Subject [GitHub] cordova-plugin-media pull request: Progress report for Media plugi...
Date Wed, 13 Aug 2014 14:23:06 GMT
Github user jsoref commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-media/pull/22#discussion_r16177733
  
    --- Diff: www/Media.js ---
    @@ -192,4 +195,16 @@ Media.onStatus = function(id, msgType, value) {
     
     };
     
    -module.exports = Media;
    +Media.onBuffered = function(id, buffered) {
    +    var media = mediaObjects[id];
    +
    +    if(media) {
    +        media.bufferedCallback && media.bufferedCallback(buffered);
    +    }
    +    else {
    +         console.error && console.error("Received Media.onBuffered callback for
unknown media :: " + id);
    +    }
    +
    +};
    +
    +module.exports = Media;
    --- End diff --
    
    the red null w/ red linefeed means you don't have a newline at the end of your file. please
add one.
    
    Also, please file a bug in issues.apache.org/jira and reference it in the commit message
(see the contribution guide...)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message