cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jsoref <...@git.apache.org>
Subject [GitHub] cordova-plugin-media pull request: Progress report for Media plugi...
Date Wed, 13 Aug 2014 14:20:05 GMT
Github user jsoref commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-media/pull/22#discussion_r16177556
  
    --- Diff: src/android/AudioPlayer.java ---
    @@ -277,6 +280,16 @@ public void onCompletion(MediaPlayer player) {
         }
     
         /**
    +     * Callback to be invoked when progress has been made on buffering media source
    +     *
    +     * @param player           The MediaPlayer that reached the end of the file
    --- End diff --
    
    `that reached the end of file` sounds wrong... based on the callback name.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message