cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jsoref <>
Subject [GitHub] cordova-plugin-media pull request: Update
Date Wed, 13 Aug 2014 14:18:43 GMT
Github user jsoref commented on a diff in the pull request:
    --- Diff: doc/ ---
    @@ -49,7 +49,7 @@ and may deprecate the current APIs.
     ## Media
    -    var media = new Media(src, mediaSuccess, [mediaError], [mediaStatus]);
    --- End diff --
    Do we usually use this notation *in* JavaScript?
    In JavaScript, []s usually mean _an_ Array. For an example, I'd expect:
    var media = new Media(src, mediaSuccess, mediaError, mediaStatus);
    Also, normally things should have a bug ( corresponding to the

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message