cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sgrebnov <...@git.apache.org>
Subject [GitHub] cordova-windows pull request: CB-7129 Switch to nodejs for windows...
Date Fri, 08 Aug 2014 15:55:08 GMT
Github user sgrebnov commented on the pull request:

    https://github.com/apache/cordova-windows/pull/38#issuecomment-51620450
  
    Jesse, please let me know your consideration regarding promises usage and if there are
places which should be improved. I personally tried to do my best to make code as readable
as possible, but it's not so easy taking into account async nature of shell commands. I see,
there is the same situation on Android where there are many async methods. 
    https://github.com/apache/cordova-android/blob/master/bin/templates/cordova/lib/run.js#L95
    Promises helps here a lot since we don't need to manually manage success/error callbacks/cases
and can chain them.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message