Return-Path: X-Original-To: apmail-cordova-dev-archive@www.apache.org Delivered-To: apmail-cordova-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6856511A2C for ; Tue, 15 Jul 2014 20:43:30 +0000 (UTC) Received: (qmail 42422 invoked by uid 500); 15 Jul 2014 20:43:30 -0000 Delivered-To: apmail-cordova-dev-archive@cordova.apache.org Received: (qmail 42379 invoked by uid 500); 15 Jul 2014 20:43:30 -0000 Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cordova.apache.org Delivered-To: mailing list dev@cordova.apache.org Received: (qmail 42363 invoked by uid 99); 15 Jul 2014 20:43:29 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 15 Jul 2014 20:43:29 +0000 X-ASF-Spam-Status: No, hits=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of bowserj@gmail.com designates 209.85.220.175 as permitted sender) Received: from [209.85.220.175] (HELO mail-vc0-f175.google.com) (209.85.220.175) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 15 Jul 2014 20:43:28 +0000 Received: by mail-vc0-f175.google.com with SMTP id hu12so6274735vcb.20 for ; Tue, 15 Jul 2014 13:43:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=Zmet5KI17bNsE2eOwVXLwno0wm8FbWVLoDRWFV7uFdM=; b=pr4GvCUpNh7WTbTHNKupwYaDMpIAgLLp9l3cOMbhRl6uc7f8BawN4uwUz/UOdQAH9U BNl7iJabIDcK9hW2/tgeK1mVojruEPVZ60oJVCiUsW9PS0/jUcEcDJfi9okmdJZSN6qw y+P4KqtnERowDC8jLPRwHy9fMb4edOg/KOmg9t3yJnSwhC2GvzlPC5sagb3KAVWAqAYM SKCdvfSw4j35rI3UP0S0lSUFJjytXpEgmBqzVW3YY6Q5NMowbtuj0EqfGb5rfvUSqBEb LhJk7ey6aOK9AJ0yzNQPafA3M2ECUeRH8pWTWVtgZ/XeZ5PTu0s+z11UneOsQ+xePAwX 0c0Q== MIME-Version: 1.0 X-Received: by 10.220.44.141 with SMTP id a13mr2809557vcf.71.1405456983337; Tue, 15 Jul 2014 13:43:03 -0700 (PDT) Received: by 10.220.241.208 with HTTP; Tue, 15 Jul 2014 13:43:03 -0700 (PDT) In-Reply-To: References: Date: Tue, 15 Jul 2014 13:43:03 -0700 Message-ID: Subject: Re: 4.0.x, efcedabe, Patch-Bombing and good faith From: Joe Bowser To: dev Content-Type: text/plain; charset=UTF-8 X-Virus-Checked: Checked by ClamAV on apache.org On Tue, Jul 15, 2014 at 1:24 PM, Michal Mocny wrote: > May we keep these topics within existing email threads? Some of these > topics have been addressed elsewhere and the conversation is forking. > > RE: topic branches -- thats what 4.0.x is, no? What's the topic? 4.0.x is a broad topic. If we look at my workflow for pluggable_webview, it was as follows: 1. Personal topic thread: https://github.com/infil00p/cordova-android/tree/pluggable_webview 2. Sent an e-mail asking if it was cool to add to ASF repos 3. After working on that and other issues, create a separate 4.0.x for various topic branches to be added. 4. Sent e-mail asking about rebasing to 4.0.x, get rough consensus. This process started months ago, back when we first started working on pluggable webview. Once we actually merge things in a potential release branch, we should try to not break it unless we have a good reason to not break it. This shouldn't be broken on a single person's whim. > I guess as more people > start to actually consume it, we should start to care more about compat. > We didn't care about making breaking changes in the first weeks, and now > its the end of the world (okay I'm exaggerating here, just trying to > counterbalance the original tone ;) > The problem is that this isn't the only part of the project that gets patch bombed. There's also the fact that we managed to actually get a feature working and everyone mostly agreeing how it was supposed to work, which is a really hard thing. You can try and downplay this, but if we're constantly getting into revert wars, we can't do anything else. Time I could spend on prototyping things and on our JIRA issues, which are constantly increasing, is now time I'm spending reviewing 30+ commits trying to find what broke things, and writing e-mails about them. > Also, 4.0.x also doesn't exactly have a well defined set of things to test > against, so we should discuss that tonight. I think its hard to include > other peoples demos which you don't know exist in that set.. 4.0.x has one main feature, which is pluggable webviews. It has other things, like the UriHelper logic that was created to fix how intents are managed and deprecations, but we should at least make sure we don't break the one feature that we agreed upon. Right now there's classes that are missing that make this webview not work: https://github.com/clelland/cordova-crosswalk-engine/tree/plugin_with_arm_binary.