Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
Received-SPF: pass (nike.apache.org: domain of purplecabbage@gmail.com
 designates 209.85.220.178 as permitted sender)
MIME-Version: 1.0
In-Reply-To: 
 <CAFNH95QonXdyG1ov2GzaqB0Wv3aT8D7-hvRoacwfcGLq=b8JMQ@mail.gmail.com>
References: 
 <aead8119268c4bc4b1fd1d05e8309543@BL2PR03MB417.namprd03.prod.outlook.com>
	<CABiQX1W0CM9HQzKjDHKei3sTb-8Qcfy2nkw1Nfn5U_+yT+rehg@mail.gmail.com>
	<etPan.53baa1a4.66ef438d.b7e3@HooperX.local>
	<373764ec305840ab8382b3a1023dc191@BY2PR03MB428.namprd03.prod.outlook.com>
	<OF7F9886B4.C147C70F-ON87257D11.00666B38-85257D11.00668158@us.ibm.com>
	<CAOBL_k4cTCw5XCnkRSCshpWLFv-EM_jFQyvYpTUV859Zan8cpQ@mail.gmail.com>
	<CAKP6k2vBgYZWxdbwCvZneYgw+rRCk=AW9_O0-gp0snzYZ3cGyg@mail.gmail.com>
	<CAOBL_k4vQLumpdAV0KNtcuChWOGqkUb+7L0z=wdP5wuWWBzteA@mail.gmail.com>
	<CAOBL_k7nka2OayJ8=YVKRKh17srA2JXTUGqrn_qEfWKg23=Myw@mail.gmail.com>
	<CAFNH95QonXdyG1ov2GzaqB0Wv3aT8D7-hvRoacwfcGLq=b8JMQ@mail.gmail.com>
Date: Thu, 10 Jul 2014 17:58:18 -0700
Message-ID: 
 <CAKP6k2vTubbZdVx4yBc4AVb+zeGU9ONgj0+Y7r6q+U0Uem6k1Q@mail.gmail.com>
Subject: Re: Android: add support of min/max/target SDK to config.xml
From: Jesse <purplecabbage@gmail.com>
To: "dev@cordova.apache.org" <dev@cordova.apache.org>
Content-Type: multipart/alternative; boundary=001a11c1be70dd081b04fde06ff0

--001a11c1be70dd081b04fde06ff0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Somewhat to Joe's point, anyone who knows that they want this feature can
probably find their own work-around. ( as Frederico proves )
Joe has the strongest feelings on this, such that he keeps getting pulled
into the conversation even though he is on holiday.
I think we should shelve this conversation until next week, when we can dig
into it deeper.

@purplecabbage
risingj.com


On Thu, Jul 10, 2014 at 5:22 PM, Frederico Galv=C3=A3o <
frederico.galvao@pontoget.com.br> wrote:

> Are you guyus against the actual implementation being suggested or are yo=
u
> against the idea as a whole?
> If the answer to the above is "I +1 the idea but -1 the current
> implementation being suggested", then ignore the rest of this message, an=
d
> I'll say that I'm looking foward to this feature being released (although
> it's not a showstopper for me, I'm used to messing with the native shell
> after Cordova has spit it out for me).
>
> First I'll state that I agree that in no reasonable situation targetSdk
> should NOT be equal to the most updated(Android) and suported(Cordova)
> version.
>
> Unless you intercept ant/gradle at a fundamental time in the build proces=
s
> and force a certain sdkVersion (be it min, max, or target), Cordova alrea=
dy
> can't protect itself against me changing those options on my
> AndroidManifest.xml. By the way, this is exactly what I've been doing for=
 a
> year and a half now, even with cordova 3.x.
> So, if you mean a -1 to this trying to protect the app from building whil=
e
> targetting "wrong" versions, I'll disagree with you.
>
> However, I may take the need and consequences of this feature differently
> than others because I keep and maintain the platform folders in VCS
> (against recommendations from the docs) and track changes to it every tim=
e
> a plugin is installed or a new version of Cordova is released, just becau=
se
> the CLI alongside config.xml can't handle all the changes I need done on
> the native side as of today.
>
>
> 2014-07-10 17:28 GMT-03:00 Joe Bowser <bowserj@gmail.com>:
>
> > On 10 Jul 2014 19:58, bowserj@gmail.com wrote:
> > >
> > >
> > > Completely disagree.  All this will do is make things not build and
> > confuse users. It's our job to try and abstract this out and when we le=
t
> > users control this, their apps are terrible.  This feature is harmful a=
nd
> > shouldn't be included.
> >
> > Decided that I should elaborate. If you see a legacy menu on a PhoneGap
> App
> > like the Canadian Avalanche Centre, you'll notice a menu that doesn't d=
o
> > anything.  This is what we want to avoid.
> >
> > Apologies for singling this app out, there are others, but this is an
> app I
> > actually use occasionally.
> >
> > >
> > > > @purplecabbage
> > > > risingj.com
> > > >
> > > >
> > > > On Thu, Jul 10, 2014 at 11:58 AM, Joe Bowser <bowserj@gmail.com>
> > wrote:
> > > >
> > > > > -1
> > > > >
> > > > > I like adding min, but max and target build can really break the
> > build,
> > > > > especially when we try and use newer Chromium features.  PG Build
> has
> > this
> > > > > only because a method that we were using was removed from Cordova
> and
> > they
> > > > > have to support old versions.  We want people to upgrade Cordova
> and
> > this
> > > > > makes it easier for people to stick to broken versions.
> > > > > On Jul 10, 2014 11:40 AM, "Lisa Seacat DeLuca" <ldeluca@us.ibm.co=
m
> >
> > wrote:
> > > > >
> > > > > > Sergey, this is awesome!  Once we get your changes pulled in we
> > should
> > > > > > also update the documentation.  I can see this being a popular
> > little
> > > > > > feature for users.
> > > > > >
> > > > > >
> > > > > > Lisa
> > > > > > @LisaSeacat
> > > > > >
> > > > > >
> > > > > >
> > > > > > [image: Inactive hide details for "Sergey Grebnov (Akvelon)"
> > > > > ---07/10/2014
> > > > > > 04:23:07 AM---Implemented, pls take a look: https://github.c
> > ]"Sergey
> > > > > > Grebnov (Akvelon)" ---07/10/2014 04:23:07 AM---Implemented, pls
> > take a
> > > > > > look: https://github.com/apache/cordova-lib/pull/56/files
> > > > > >
> > > > > > From: "Sergey Grebnov (Akvelon)" <v-segreb@microsoft.com>
> > > > > > To: "dev@cordova.apache.org" <dev@cordova.apache.org>
> > > > > > Date: 07/10/2014 04:23 AM
> > > > > > Subject: RE: Android: add support of min/max/target SDK to
> > config.xml
> > > > > > ------------------------------
> > > > > >
> > > > > >
> > > > > >
> > > > > > Implemented, pls take a look:
> > > > > > https://github.com/apache/cordova-lib/pull/56/files
> > > > > > https://issues.apache.org/jira/browse/CB-7114
> > > > > >
> > > > > > Thx!
> > > > > > Sergey
> > > > > > -----Original Message-----
> > > > > > From: tommy-carlos williams [mailto:tommy@devgeeks.org
> > > > > > <tommy@devgeeks.org>]
> > > > > > Sent: Monday, July 7, 2014 5:33 PM
> > > > > > To: dev@cordova.apache.org
> > > > > > Subject: Re: Android: add support of min/max/target SDK to
> > config.xml
> > > > > >
> > > > > > +1
> > > > > >
> > > > > > Another step towards build-artefact-land.
> > > > > >
> > > > > >
> > > > > >
> > > > > > On 7 July 2014 at 23:29:25, Andrew Grieve (agrieve@chromium.org=
)
> > wrote:
> > > > > >
> > > > > > I'd love to see this added.
> > > > > >
> > > > > >
> > > > > > On Mon, Jul 7, 2014 at 7:29 AM, Sergey Grebnov (Akvelon) <
> > > > > > v-segreb@microsoft.com> wrote:
> > > > > >
> > > > > > > Propose to add support of the following Android specific
> settings
> > to
> > > > > > > config.xml similar to PG Build[2]. Optional, could be used to
> > override
> > > > > > > default template values. I think this could be very useful an=
d
> > will
> > > > > > > implement this if we agree. Thoughts?
> > > > > > >
> > > > > > > <preference name=3D"android-minSdkVersion" value=3D"10" />
> > <preference
> > > > > > > name=3D"android-targetSdkVersion" value=3D"19" /> <preference
> > > > > > > name=3D"android-maxSdkVersion" value=3D"20" />
> > > > > > >
> > > > > > > [1]
> > > > > > >
> > http://developer.android.com/guide/topics/manifest/uses-sdk-element.ht
> > > > > > > ml
> > > > > > > [2]
> > > > > > >
> > http://docs.build.phonegap.com/en_US/configuring_preferences.md.html#_
> > > > > > > android_only
> > > > > > >
> > > > > > > Thx!
> > > > > > > Sergey
> > > > > > >
> > > > > >
> > > > > >
> > > > > >
> > > > >
> >
>
>
>
> --
>
> *Frederico Galv=C3=A3o*
>
> Diretor de Tecnologia
>
> PontoGet Inova=C3=A7=C3=A3o Web
>
>
> ( +55(62) 8131-5720
>
> * www.pontoget.com.br <http://www.pontoget.com/>
>

--001a11c1be70dd081b04fde06ff0--