Return-Path: 
 <dev-return-36383-apmail-cordova-dev-archive=cordova.apache.org@cordova.apache.org>
X-Original-To: apmail-cordova-dev-archive@www.apache.org
Delivered-To: apmail-cordova-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 6913D1157A
	for <apmail-cordova-dev-archive@www.apache.org>;
 Wed, 30 Jul 2014 18:35:08 +0000 (UTC)
Received: (qmail 94919 invoked by uid 500); 30 Jul 2014 18:35:08 -0000
Delivered-To: apmail-cordova-dev-archive@cordova.apache.org
Received: (qmail 94884 invoked by uid 500); 30 Jul 2014 18:35:08 -0000
Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@cordova.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@cordova.apache.org>
List-Post: <mailto:dev@cordova.apache.org>
List-Id: <dev.cordova.apache.org>
Reply-To: dev@cordova.apache.org
Delivered-To: mailing list dev@cordova.apache.org
Received: (qmail 94873 invoked by uid 99); 30 Jul 2014 18:35:07 -0000
Received: from tyr.zones.apache.org (HELO tyr.zones.apache.org)
 (140.211.11.114)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 30 Jul 2014 18:35:07 +0000
Received: by tyr.zones.apache.org (Postfix, from userid 65534)
	id 8FFB899FBA7; Wed, 30 Jul 2014 18:35:07 +0000 (UTC)
From: jsoref <git@git.apache.org>
To: dev@cordova.apache.org
Reply-To: dev@cordova.apache.org
References: <git-pr-18-cordova-plugin-globalization@git.apache.org>
In-Reply-To: <git-pr-18-cordova-plugin-globalization@git.apache.org>
Subject: [GitHub] cordova-plugin-globalization pull request: BB10
 implementation
Content-Type: text/plain
Message-Id: <20140730183507.8FFB899FBA7@tyr.zones.apache.org>
Date: Wed, 30 Jul 2014 18:35:07 +0000 (UTC)

Github user jsoref commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-globalization/pull/18#discussion_r15603131
  
    --- Diff: src/blackberry10/native/public/json_batchallocator.h ---
    @@ -0,0 +1,125 @@
    +#ifndef JSONCPP_BATCHALLOCATOR_H_INCLUDED
    +# define JSONCPP_BATCHALLOCATOR_H_INCLUDED
    +
    +# include <stdlib.h>
    +# include <assert.h>
    +
    +# ifndef JSONCPP_DOC_EXCLUDE_IMPLEMENTATION
    +
    +namespace Json {
    +
    +/* Fast memory allocator.
    + *
    + * This memory allocator allocates memory for a batch of object (specified by
    + * the page size, the number of object in each page).
    + *
    + * It does not allow the destruction of a single object. All the allocated objects
    + * can be destroyed at once. The memory can be either released or reused for future
    + * allocation.
    + * 
    + * The in-place new operator must be used to construct the object using the pointer
    + * returned by allocate.
    + */
    +template<typename AllocatedType
    +        ,const unsigned int objectPerAllocation>
    +class BatchAllocator
    +{
    +public:
    +   typedef AllocatedType Type;
    +
    +   BatchAllocator( unsigned int objectsPerPage = 255 )
    +      : freeHead_( 0 )
    +      , objectsPerPage_( objectsPerPage )
    +   {
    +//      printf( "Size: %d => %s\n", sizeof(AllocatedType), typeid(AllocatedType).name() );
    +      assert( sizeof(AllocatedType) * objectPerAllocation >= sizeof(AllocatedType *) ); // We must be able to store a slist in the object free space.
    +      assert( objectsPerPage >= 16 );
    +      batches_ = allocateBatch( 0 );   // allocated a dummy page
    +      currentBatch_ = batches_;
    +   }
    +
    +   ~BatchAllocator()
    +   {
    +      for ( BatchInfo *batch = batches_; batch;  )
    +      {
    +         BatchInfo *nextBatch = batch->next_;
    +         free( batch );
    +         batch = nextBatch;
    +      }
    +   }
    +
    +   /// allocate space for an array of objectPerAllocation object.
    +   /// @warning it is the responsability of the caller to call objects constructors.
    --- End diff --
    
    sp: responsability 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---