Return-Path: 
 <dev-return-36122-apmail-cordova-dev-archive=cordova.apache.org@cordova.apache.org>
X-Original-To: apmail-cordova-dev-archive@www.apache.org
Delivered-To: apmail-cordova-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id C77B3117A7
	for <apmail-cordova-dev-archive@www.apache.org>;
 Mon, 21 Jul 2014 21:56:41 +0000 (UTC)
Received: (qmail 10125 invoked by uid 500); 21 Jul 2014 21:56:39 -0000
Delivered-To: apmail-cordova-dev-archive@cordova.apache.org
Received: (qmail 10054 invoked by uid 500); 21 Jul 2014 21:56:39 -0000
Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@cordova.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@cordova.apache.org>
List-Post: <mailto:dev@cordova.apache.org>
List-Id: <dev.cordova.apache.org>
Reply-To: dev@cordova.apache.org
Delivered-To: mailing list dev@cordova.apache.org
Received: (qmail 8913 invoked by uid 99); 21 Jul 2014 21:56:38 -0000
Received: from tyr.zones.apache.org (HELO tyr.zones.apache.org)
 (140.211.11.114)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 21 Jul 2014 21:56:38 +0000
Received: by tyr.zones.apache.org (Postfix, from userid 65534)
	id A396B9AE06D; Mon, 21 Jul 2014 21:56:38 +0000 (UTC)
From: jkeshavarzi <git@git.apache.org>
To: dev@cordova.apache.org
Reply-To: dev@cordova.apache.org
References: <git-pr-169-cordova-blackberry@git.apache.org>
In-Reply-To: <git-pr-169-cordova-blackberry@git.apache.org>
Subject: [GitHub] cordova-blackberry pull request: Fixed issue: --buildId will
 disna...
Content-Type: text/plain
Message-Id: <20140721215638.A396B9AE06D@tyr.zones.apache.org>
Date: Mon, 21 Jul 2014 21:56:38 +0000 (UTC)

Github user jkeshavarzi commented on a diff in the pull request:

    https://github.com/apache/cordova-blackberry/pull/169#discussion_r15199356
  
    --- Diff: bin/templates/project/cordova/lib/cmdline.js ---
    @@ -30,7 +30,8 @@ command
         .option('-p, --params <params JSON file>', 'Specifies additional parameters to pass to downstream tools.')
         .option('--appdesc <filepath>', 'Optionally specifies the path to the bar descriptor file (bar-descriptor.xml). For internal use only.')
         .option('-v, --verbose', 'Turn on verbose messages')
    -    .option('-l, --loglevel <loglevel>', 'set the logging level (error, warn, verbose)');
    +    .option('-l, --loglevel <loglevel>', 'set the logging level (error, warn, verbose)')
    +    .option('--signing', 'if signing the app');
    --- End diff --
    
    Can we update the description to be a bit more informative? This will confuse users. They will think it's a required field for signing. Maybe something like "Optionally forces whether to sign the build (true by default for release builds)".


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---