Return-Path: X-Original-To: apmail-cordova-dev-archive@www.apache.org Delivered-To: apmail-cordova-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id CB79411362 for ; Mon, 14 Jul 2014 20:20:44 +0000 (UTC) Received: (qmail 25797 invoked by uid 500); 14 Jul 2014 20:20:44 -0000 Delivered-To: apmail-cordova-dev-archive@cordova.apache.org Received: (qmail 25762 invoked by uid 500); 14 Jul 2014 20:20:44 -0000 Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cordova.apache.org Delivered-To: mailing list dev@cordova.apache.org Received: (qmail 25751 invoked by uid 99); 14 Jul 2014 20:20:44 -0000 Received: from tyr.zones.apache.org (HELO tyr.zones.apache.org) (140.211.11.114) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 14 Jul 2014 20:20:44 +0000 Received: by tyr.zones.apache.org (Postfix, from userid 65534) id CF2D1931BDF; Mon, 14 Jul 2014 20:20:43 +0000 (UTC) From: martincgg To: dev@cordova.apache.org Reply-To: dev@cordova.apache.org References: In-Reply-To: Subject: [GitHub] cordova-plugin-file pull request: CB-7093 Ported automated File te... Content-Type: text/plain Message-Id: <20140714202043.CF2D1931BDF@tyr.zones.apache.org> Date: Mon, 14 Jul 2014 20:20:43 +0000 (UTC) Github user martincgg commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/60#issuecomment-48954105 The last commit on which is based is after this one: https://git-wip-us.apache.org/repos/asf?p=cordova-mobile-spec.git;a=commit;h=005641907754e04895135e502ef9fcb6f24d353f Made on 2014-06-23 by Martin Bektchiev- Fix failing battery tests. Add a dummy battery listener There's no file tests after that commit. Based on some fixes that I've sent to mobile-spec. https://github.com/apache/cordova-mobile-spec/pull/79 https://github.com/apache/cordova-mobile-spec/pull/75 By the way, your changes were good, I tried to remove most of the comments and old content, some of them escaped from my sight, also it makes perfect sense use URL instead of URI since is deprecated. Ian, about the change that you made on plugin.xml, I think Andrew Grieve point out that those changes would be made by adding some improvements to the CLI, and avoid include tests in the release version of the plugin. Check this comment on this PR. https://github.com/apache/cordova-plugin-media-capture/pull/19 Thanks for taking this on, I'll be delivering the manual tests shortly. Thanks @clelland --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---