Return-Path: X-Original-To: apmail-cordova-dev-archive@www.apache.org Delivered-To: apmail-cordova-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0D44211BB8 for ; Wed, 2 Jul 2014 16:21:48 +0000 (UTC) Received: (qmail 31862 invoked by uid 500); 2 Jul 2014 16:21:47 -0000 Delivered-To: apmail-cordova-dev-archive@cordova.apache.org Received: (qmail 31822 invoked by uid 500); 2 Jul 2014 16:21:47 -0000 Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cordova.apache.org Delivered-To: mailing list dev@cordova.apache.org Received: (qmail 31809 invoked by uid 99); 2 Jul 2014 16:21:47 -0000 Received: from tyr.zones.apache.org (HELO tyr.zones.apache.org) (140.211.11.114) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 02 Jul 2014 16:21:47 +0000 Received: by tyr.zones.apache.org (Postfix, from userid 65534) id 1E704993E20; Wed, 2 Jul 2014 16:21:47 +0000 (UTC) From: kamrik To: dev@cordova.apache.org Reply-To: dev@cordova.apache.org References: In-Reply-To: Subject: [GitHub] cordova-lib pull request: CB-6776 Make project/.cordova/config.jso... Content-Type: text/plain Message-Id: <20140702162147.1E704993E20@tyr.zones.apache.org> Date: Wed, 2 Jul 2014 16:21:47 +0000 (UTC) Github user kamrik commented on the pull request: https://github.com/apache/cordova-lib/pull/9#issuecomment-47798569 This seems to deal quite a lot with check_requirements(). Considering the discussion last Thursday, should we first stop using check_requirements() and then add the remaining changes from this PR? A nit: The lazy_load.mixin() func seems to be the same as underscore.extend() http://underscorejs.org/#extend Other than that looks good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---