cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pascalw <...@git.apache.org>
Subject [GitHub] cordova-lib pull request: CB-7124: Fix `cordova platform add <plat...
Date Thu, 17 Jul 2014 18:36:03 GMT
GitHub user pascalw opened a pull request:

    https://github.com/apache/cordova-lib/pull/61

    CB-7124: Fix `cordova platform add <platform>@version` with `--usegit`

    https://issues.apache.org/jira/browse/CB-7124
    
    The `cordova_git` function didn't consider that platform strings can contain `@version`
annotations. I refactored the code a bit to keep the `@version` check in a single place, namely
in the `Platform` object.
    
    Please let me know if this patch is acceptable in this form.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/pascalw/cordova-lib CB-7124

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-lib/pull/61.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #61
    
----
commit 3ae36ea2011d092769ca72db6b1e258f69a647a5
Author: Pascal Widdershoven <pascal@kabisa.nl>
Date:   2014-07-12T14:32:47Z

    Wrap the cordova platform string in Platform object with name & version
    
    This prevents having to duplicate the check wether or not the platform
    string specifies a version or not.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message