cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From martincgg <...@git.apache.org>
Subject [GitHub] cordova-plugin-file pull request: CB-7093 Ported automated File te...
Date Tue, 08 Jul 2014 22:12:04 GMT
GitHub user martincgg opened a pull request:

    https://github.com/apache/cordova-plugin-file/pull/60

    CB-7093 Ported automated File tests for cordova-plugin-test-framework

    Ported 131 File automated tests from mobilespec.
    
    Jasmine version: ported from v1.3 to v2.0
    
    Features:
    -No spies.
    -No timeouts.
    -Tests failing faster, when a error callback or unexpected success callback is received,
the test fails immediately.
    -Jasmine report with more information about the failed operation, which contains the operation
and a description about it.
    -Jasmine reports include error callback object.
    -Code reduced and simplified.
    
    Bugs:
    Found problem described in the code at:
    https://github.com/martincgg/cordova-plugin-file/blob/dcc34b628c9896084b886747308171e63f684270/test/tests.js#L2057
    
    https://github.com/martincgg/cordova-plugin-file/blob/dcc34b628c9896084b886747308171e63f684270/test/tests.js#L2110
    
    Issue related (file spec 85 & 92): CB-7095

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/martincgg/cordova-plugin-file CB-7093

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-file/pull/60.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #60
    
----
commit dcc34b628c9896084b886747308171e63f684270
Author: Martin Gonzalez <martin.c.glez.glez@gmail.com>
Date:   2014-07-08T22:05:38Z

    CB-7093 Ported automated file tests
    
    Ported File plugin automated tests from mobilespec,
    Jasmine version: ported from 1.3 to 2.0
    Features:
    -No spies.
    -No timeouts.
    -Tests fails faster, when a error callback or unexpected callback is
    received the test fails imediately.
    -Jasmine report with more information about the failed operation, which
    contains the operation and a description about it.
    -Jasmine reports include error callback object.
    -Code reduced and simplified.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message