cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bradberger <...@git.apache.org>
Subject [GitHub] cordova-plugin-statusbar pull request: Update backgroundColorByHex...
Date Mon, 21 Jul 2014 07:43:01 GMT
GitHub user bradberger opened a pull request:

    https://github.com/apache/cordova-plugin-statusbar/pull/11

    Update backgroundColorByHexString function

    The implementation when `hexString.length == 4` was a bit off. The current version either
doesn't actually use the `split` variable, so that variable could be removed, or used in place
accessing the string characters as they are now. Opted for the former in this case, though
it doesn't really matter.
    
    Since the length is always going to be a number, also changed to `===` instead, as well
as updated the check for `#` at the beginning of the string. Since it's always looking for
the `#` tat the beginning `charAt(0)` seems to be a better fit.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/bradberger/cordova-plugin-statusbar patch-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-statusbar/pull/11.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #11
    
----
commit d9a8528c8baaa1b94efa0b0efea0c22ccf988cf1
Author: Brad Berger <brad@bradb.net>
Date:   2014-07-21T07:42:44Z

    Update backgroundColorByHexString function
    
    The implementation when `hexString.length == 4` was a bit off. The current version either
doesn't actually use the `split` variable, so that variable could be removed, or used in place
accessing the string characters as they are now. Opted for the former in this case, though
it doesn't really matter.
    
    Since the length is always going to be a number, also changed to `===` instead, as well
as updated the check for `#` at the beginning of the string. Since it's always looking for
the `#` tat the beginning `charAt(0)` seems to be a better fit.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message