cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From lapo-luchini <...@git.apache.org>
Subject [GitHub] cordova-ios pull request: Fix __PROECT_NAME__ replacing code
Date Fri, 18 Jul 2014 14:42:12 GMT
GitHub user lapo-luchini opened a pull request:

    https://github.com/apache/cordova-ios/pull/100

    Fix __PROECT_NAME__ replacing code

    `&` is a special character for `sed` and this fixes the problem of having `__PROJECT_NAME__`
in the final output when the project name contains an ampersand, this is not only a cosmetic
issue but also leads to compilation errors:
    
        xcodebuild: error: The project 'A&B.xcodeproj' does not contain a target named
'A&B'.
        { [Error: /Users/lapo/projDir/platforms/ios/cordova/build: Command failed with exit
code 65] code: 65 }
           [error] /Users/lapo/projDir/platforms/ios/cordova/build: Command failed with exit
code 65

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/lapo-luchini/cordova-ios master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-ios/pull/100.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #100
    
----
commit f1fdb5145ea923229b2a2aec68c32d464575577c
Author: Lapo Luchini <lapo@lapo.it>
Date:   2014-07-18T14:38:10Z

    Fix __PROECT_NAME__ replacing code
    
    `&` is a special character for `sed` and this fixes the problem of having `__PROJECT_NAME__`
in the final output when the project name contains an ampersand.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message