cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Staci Cooper <staci....@gmail.com>
Subject Re: plugin-test-framework PRs
Date Wed, 30 Jul 2014 15:44:20 GMT
Sounds good, I'll get started.


On Wed, Jul 30, 2014 at 11:33 AM, Michal Mocny <mmocny@chromium.org> wrote:

> Things to help move this along:
>
> - Move test directories to "tests" and add nested plugin.xml, that would be
> a great.  You can look at an example here:
> https://github.com/apache/cordova-plugin-device/tree/master/tests
> - Test the PR locally by running the mobilespec create script to make sure
> the plugin tests install fine and run well.  (The part that adds new-style
> tests is here:
>
> https://github.com/apache/cordova-mobile-spec/blob/master/createmobilespec/createmobilespec.js#L248
> )
> - Double check to make sure we have covered all tests currently in
> mobilespec, and submit PR to remove the old tests from mobilespec app.  I
> would not like to land the new tests without removing the old tests as
> well.
>
> Thanks a bunch!
>
>
>
>
>
> On Wed, Jul 30, 2014 at 11:25 AM, Staci Cooper <staci.mcl@gmail.com>
> wrote:
>
> > Just want to bump this thread.
> >
> > Michal -- that all sounds great. Let me know if there's anything I can do
> > to help with integration, or if the IBM committers can help with merging.
> > Should we go ahead and add nested plugin.xml files to the PRs?
> >
> > Also, for reference: I tested all of my PRs on wp8 with a comparison with
> > mobile-spec's behavior, as did Martin with his. Edna and Martin have also
> > been testing on ios and android respectively.
> >
> >
> > On Tue, Jul 22, 2014 at 9:52 AM, Michal Mocny <mmocny@chromium.org>
> wrote:
> >
> > > Just a quick update since its been a few days.
> > >
> > > - Mobile-spec now builds with new-style tests bundled in (there is a
> > button
> > > to launch this on the first screen), and the createmobilespec.sh script
> > > will automatically install plugin tests.
> > > - Last week I moved device tests from mobile-spec over to plugin tests,
> > and
> > > modified the file plugin tests to use a nested plugin.xml.
> > > - File and FileTransfer tests are tightly coupled in mobile-spec, and
> > > should be removed together.  I have this mostly finished locally, but..
> > > - I want to set up ci.cordova.io to include results of new-style tests
> > > before ripping out huge portions of mobile spec, which is what I'm
> doing
> > > now.
> > >
> > > Few notes:
> > > - The PR's have created a "test" folder, but I had written scripts to
> > > expect "tests" folder.  Its easy to change or just accept both, but I
> > > wonder if we should settle on a single convention.  Total bikeshed
> topic,
> > > so I'll just pick one.
> > > - PR's for new tests seem to be well isolated from each other (unlike
> > > mobilespec).  Aka you can run FileTransfer tests without File tests.
> >  Good
> > > job!
> > >
> > > -Michal
> > >
> > >
> > > On Wed, Jul 16, 2014 at 5:02 PM, Michal Mocny <mmocny@chromium.org>
> > wrote:
> > >
> > > > Sure, I was actually already planning to take a look this week.  I
> was
> > > > working on mobile-spec today and have *also* ported device tests :P
>  I
> > > > should have looked at the PR's first!  Will start these tomorrow.
> > > >
> > > > The plan for mobile spec was just to have a transition path, by
> adding
> > a
> > > > link to the old mobile-spec app to open the new-style-tests harness.
> > >  Then,
> > > > as we move tests from mobile-spec to new-style, we should remove the
> > old
> > > > tests from mobile-spec.  Doing it this way means cordova committers
> > have
> > > a
> > > > single place to run all tests, and when mobile-spec is 100%
> completely
> > > > deprecated, then we can just switch the start page with no change to
> > > > committers.
> > > >
> > > > Thanks for your work here!
> > > >
> > > > -Michal
> > > >
> > > >
> > > > On Wed, Jul 16, 2014 at 4:38 PM, Staci Cooper <staci.mcl@gmail.com>
> > > wrote:
> > > >
> > > >> Hi all,
> > > >>
> > > >> Several of us at IBM have been working on porting tests from
> > mobile-spec
> > > >> to
> > > >> the plugin-test-framework. I believe we have pull requests out for
> all
> > > of
> > > >> the automated tests; we also have the manual tests ported and are
> just
> > > >> wrapping up testing on ios/android, so those additional pull
> requests
> > > >> should be out by tomorrow evening.
> > > >>
> > > >> Can we get these reviewed soon to avoid getting out of sync with
> > mobile
> > > >> spec? Michal, if you have time to take a look that would be
> fantastic;
> > > we
> > > >> can also get some of the IBM committers to help if needed.
> > > >>
> > > >> Related note: I see that Michal added the new style tests to
> > > mobile-spec,
> > > >> but is the plan for plugin-test-framework to be supplementary to
> > > >> mobile-spec tests? It seems there would be problems keeping them in
> > > sync.
> > > >> If it hasn't already been suggested, I propose removing mobile-spec
> > > tests
> > > >> as the ported tests get merged in. The mobile-spec project would
> > > >> eventually
> > > >> become a shell project with all tests run through
> > plugin-test-framework
> > > >> and
> > > >> installed plugins.
> > > >>
> > > >> Thanks,
> > > >> Staci Cooper
> > > >>
> > > >
> > > >
> > >
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message