cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Axel Nennker <ignisvul...@gmail.com>
Subject Re: [GitHub] cordova-lib pull request: CB-7132: fix regression regarding defaul...
Date Tue, 15 Jul 2014 04:34:07 GMT
Merge artefact.
Am 15.07.2014 03:46 schrieb "kamrik" <git@git.apache.org>:

> Github user kamrik commented on a diff in the pull request:
>
>     https://github.com/apache/cordova-lib/pull/58#discussion_r14914123
>
>     --- Diff: cordova-lib/src/cordova/metadata/android_parser.js ---
>     @@ -42,6 +42,12 @@ module.exports = function android_parser(project) {
>          this.android_config = path.join(this.path, 'res', 'xml',
> 'config.xml');
>      };
>
>     +// Returns a promise.
>     +module.exports.check_requirements = function(project_root) {
>     +    // Rely on platform's bin/create script to check requirements.
>     +    return Q(true);
>     +};
>     +
>     --- End diff --
>
>     Is this intentional or a merge artifact?
>     The check_reqs functions were all removed as part of CB-7091
>     commits:
>
> https://github.com/apache/cordova-lib/commit/ab49973560ccb7a1ea37d9f5db4e497ef0ce92d1
>
> https://github.com/apache/cordova-lib/commit/153092f2c235185c7f141979a550779800954a92
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message