cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Axel Nennker <ignisvul...@gmail.com>
Subject Re: [GitHub] cordova-lib pull request: CB-7132: fix regression regarding defaul...
Date Fri, 18 Jul 2014 21:36:11 GMT
What do you mean with "blank splash"? Splash without src?
If yes then I consider this illegal anyway.

I tested these cases on Android:
- no splash in config.xml
- one default splash. No density.
- all densities that exist in project.
- one density (xhdpi)

All worked.

Axel

PS: I am traveling and am not able to work on this. I think this PR is an
improvement and should be merged even if new bugs were discovered.
Am 18.07.2014 21:26 schrieb "VVelda" <git@git.apache.org>:

> Github user VVelda commented on the pull request:
>
>     https://github.com/apache/cordova-lib/pull/58#issuecomment-49475950
>
>     Now it works good with icons. But I have one question, you plain that
> your changes removes splashcreen from project, if in config.xml is blank
> <splash /> tag, don't you?
>     But if I do it and then call cordova prepare, it do, what it shoudl
> do, but also error occurs:
>
>     shell.js: internal error
>     TypeError: Cannot use 'in' operator to search for 'length' in undefined
>         at Object._cp
> (C:\Users\Velda\AppData\Roaming\npm\node_modules\cordova\node_modules\cordova-lib\node_modules\shelljs\shell.js:267:26)
>         at Object.cp
> (C:\Users\Velda\AppData\Roaming\npm\node_modules\cordova\node_modules\cordova-lib\node_modules\shelljs\shell.js:1491:23)
>         at Object.module.exports.handleSplashes
> (C:\Users\Velda\AppData\Roaming\npm\node_modules\cordova\node_modules\cordova-lib\src\cordova\metadata\android_parser.js:115:11)
>         at Object.module.exports.update_from_config
> (C:\Users\Velda\AppData\Roaming\npm\node_modules\cordova\node_modules\cordova-lib\src\cordova\metadata\android_parser.js:228:14)
>         at Object.module.exports.update_project
> (C:\Users\Velda\AppData\Roaming\npm\node_modules\cordova\node_modules\cordova-lib\src\cordova\metadata\android_parser.js:337:18)
>         at
> C:\Users\Velda\AppData\Roaming\npm\node_modules\cordova\node_modules\cordova-lib\src\cordova\prepare.js:116:31
>         at _fulfilled
> (C:\Users\Velda\AppData\Roaming\npm\node_modules\cordova\node_modules\q\q.js:798:54)
>         at self.promiseDispatch.done
> (C:\Users\Velda\AppData\Roaming\npm\node_modules\cordova\node_modules\q\q.js:827:30)
>         at Promise.promise.promiseDispatch
> (C:\Users\Velda\AppData\Roaming\npm\node_modules\cordova\node_modules\q\q.js:760:13)
>         at
> C:\Users\Velda\AppData\Roaming\npm\node_modules\cordova\node_modules\q\q.js:821:14
>
>     I don't know if it's problem with code, or I'm missing something. (I
> have updated only android-parser.js to test it)
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message