cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Frederico Galvão <frederico.gal...@pontoget.com.br>
Subject Re: Android: add support of min/max/target SDK to config.xml
Date Fri, 11 Jul 2014 17:27:52 GMT
I'll elaborate on this topic on the next couple of days then and come back
with a full feedback on this and folder structure + incremental builds next
week. That'll give all of us time to think and get into flow again.


2014-07-10 23:46 GMT-03:00 Joe Bowser <bowserj@gmail.com>:

> On 11 Jul 2014 00:22, "Frederico Galvão" <frederico.galvao@pontoget.com.br
> >
> wrote:
> >
> > Are you guyus against the actual implementation being suggested or are
> you
> > against the idea as a whole?
>
> A bit of both, assuming you didn't add this feature. See below.
>
> > If the answer to the above is "I +1 the idea but -1 the current
> > implementation being suggested", then ignore the rest of this message,
> and
> > I'll say that I'm looking foward to this feature being released (although
> > it's not a showstopper for me, I'm used to messing with the native shell
> > after Cordova has spit it out for me).
> >
> > First I'll state that I agree that in no reasonable situation targetSdk
> > should NOT be equal to the most updated(Android) and suported(Cordova)
> > version.
>
> Awesome. Can this have an error appear when users break this?  Like for
> example, target a min API below 10, or mismatch the target?
>
> > Unless you intercept ant/gradle at a fundamental time in the build
> process
> > and force a certain sdkVersion (be it min, max, or target), Cordova
> already
> > can't protect itself against me changing those options on my
> > AndroidManifest.xml. By the way, this is exactly what I've been doing for
> a
> > year and a half now, even with cordova 3.x.
> > So, if you mean a -1 to this trying to protect the app from building
> while
> > targetting "wrong" versions, I'll disagree with you.
> >
>
> Many of our users don't fiddle with AndroidManifest.xml until they have to
> release the app.
>
> > However, I may take the need and consequences of this feature differently
> > than others because I keep and maintain the platform folders in VCS
> > (against recommendations from the docs) and track changes to it every
> time
>
> Everyone does, because the platforms aren't build artifacts yet. I see this
> feature not really helping make that happen without more thought at the
> very least.
>
> > a plugin is installed or a new version of Cordova is released, just
> because
> > the CLI alongside config.xml can't handle all the changes I need done on
> > the native side as of today.
> >
>
> Where does it come short? I can say where I think it does, but this would
> actually help us out a bit.  Your feature may make sense if it was more
> strict in how it is used, so I'm not as against it as I was initially.
> (Remember, I'm supposed to be on PTO, and I have a prepaid with no tether
> and a crap WiFi connection to peck this out on.)
>
> >
> > 2014-07-10 17:28 GMT-03:00 Joe Bowser <bowserj@gmail.com>:
> >
> > > On 10 Jul 2014 19:58, bowserj@gmail.com wrote:
> > > >
> > > >
> > > > Completely disagree.  All this will do is make things not build and
> > > confuse users. It's our job to try and abstract this out and when we
> let
> > > users control this, their apps are terrible.  This feature is harmful
> and
> > > shouldn't be included.
> > >
> > > Decided that I should elaborate. If you see a legacy menu on a PhoneGap
> App
> > > like the Canadian Avalanche Centre, you'll notice a menu that doesn't
> do
> > > anything.  This is what we want to avoid.
> > >
> > > Apologies for singling this app out, there are others, but this is an
> app I
> > > actually use occasionally.
> > >
> > > >
> > > > > @purplecabbage
> > > > > risingj.com
> > > > >
> > > > >
> > > > > On Thu, Jul 10, 2014 at 11:58 AM, Joe Bowser <bowserj@gmail.com>
> > > wrote:
> > > > >
> > > > > > -1
> > > > > >
> > > > > > I like adding min, but max and target build can really break
the
> > > build,
> > > > > > especially when we try and use newer Chromium features.  PG
Build
> has
> > > this
> > > > > > only because a method that we were using was removed from Cordova
> and
> > > they
> > > > > > have to support old versions.  We want people to upgrade Cordova
> and
> > > this
> > > > > > makes it easier for people to stick to broken versions.
> > > > > > On Jul 10, 2014 11:40 AM, "Lisa Seacat DeLuca" <
> ldeluca@us.ibm.com
> >
> > > wrote:
> > > > > >
> > > > > > > Sergey, this is awesome!  Once we get your changes pulled
in we
> > > should
> > > > > > > also update the documentation.  I can see this being a
popular
> > > little
> > > > > > > feature for users.
> > > > > > >
> > > > > > >
> > > > > > > Lisa
> > > > > > > @LisaSeacat
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > > > [image: Inactive hide details for "Sergey Grebnov (Akvelon)"
> > > > > > ---07/10/2014
> > > > > > > 04:23:07 AM---Implemented, pls take a look: https://github.c
> > > ]"Sergey
> > > > > > > Grebnov (Akvelon)" ---07/10/2014 04:23:07 AM---Implemented,
pls
> > > take a
> > > > > > > look: https://github.com/apache/cordova-lib/pull/56/files
> > > > > > >
> > > > > > > From: "Sergey Grebnov (Akvelon)" <v-segreb@microsoft.com>
> > > > > > > To: "dev@cordova.apache.org" <dev@cordova.apache.org>
> > > > > > > Date: 07/10/2014 04:23 AM
> > > > > > > Subject: RE: Android: add support of min/max/target SDK
to
> > > config.xml
> > > > > > > ------------------------------
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > > > Implemented, pls take a look:
> > > > > > > https://github.com/apache/cordova-lib/pull/56/files
> > > > > > > https://issues.apache.org/jira/browse/CB-7114
> > > > > > >
> > > > > > > Thx!
> > > > > > > Sergey
> > > > > > > -----Original Message-----
> > > > > > > From: tommy-carlos williams [mailto:tommy@devgeeks.org
> > > > > > > <tommy@devgeeks.org>]
> > > > > > > Sent: Monday, July 7, 2014 5:33 PM
> > > > > > > To: dev@cordova.apache.org
> > > > > > > Subject: Re: Android: add support of min/max/target SDK
to
> > > config.xml
> > > > > > >
> > > > > > > +1
> > > > > > >
> > > > > > > Another step towards build-artefact-land.
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > > > On 7 July 2014 at 23:29:25, Andrew Grieve (
> agrieve@chromium.org)
> > > wrote:
> > > > > > >
> > > > > > > I'd love to see this added.
> > > > > > >
> > > > > > >
> > > > > > > On Mon, Jul 7, 2014 at 7:29 AM, Sergey Grebnov (Akvelon)
<
> > > > > > > v-segreb@microsoft.com> wrote:
> > > > > > >
> > > > > > > > Propose to add support of the following Android specific
> settings
> > > to
> > > > > > > > config.xml similar to PG Build[2]. Optional, could
be used to
> > > override
> > > > > > > > default template values. I think this could be very
useful
> and
> > > will
> > > > > > > > implement this if we agree. Thoughts?
> > > > > > > >
> > > > > > > > <preference name="android-minSdkVersion" value="10"
/>
> > > <preference
> > > > > > > > name="android-targetSdkVersion" value="19" /> <preference
> > > > > > > > name="android-maxSdkVersion" value="20" />
> > > > > > > >
> > > > > > > > [1]
> > > > > > > >
> > > http://developer.android.com/guide/topics/manifest/uses-sdk-element.ht
> > > > > > > > ml
> > > > > > > > [2]
> > > > > > > >
> > > http://docs.build.phonegap.com/en_US/configuring_preferences.md.html#_
> > > > > > > > android_only
> > > > > > > >
> > > > > > > > Thx!
> > > > > > > > Sergey
> > > > > > > >
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > >
> > >
> >
> >
> >
> > --
> >
> > *Frederico Galvão*
> >
> > Diretor de Tecnologia
> >
> > PontoGet Inovação Web
> >
> >
> > ( +55(62) 8131-5720
> >
> > * www.pontoget.com.br <http://www.pontoget.com/>
>



-- 

*Frederico Galvão*

Diretor de Tecnologia

PontoGet Inovação Web


( +55(62) 8131-5720

* www.pontoget.com.br <http://www.pontoget.com/>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message