cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From purplecabbage <>
Subject [GitHub] cordova-lib pull request: CB-7190: Add browserify support in cordo...
Date Tue, 29 Jul 2014 19:09:15 GMT
Github user purplecabbage commented on a diff in the pull request:
    --- Diff: cordova-lib/src/plugman/uninstall.js ---
    @@ -316,6 +316,10 @@ function handleUninstall(actions, platform, plugin_id, plugin_et,
project_dir, w
             // queue up the plugin so prepare can remove the config changes
             config_changes.add_uninstalled_plugin_to_prepare_queue(plugins_dir, plugin_id,
platform, is_top_level);
             // call prepare after a successful uninstall
    -        plugman.prepare(project_dir, platform, plugins_dir, www_dir, is_top_level);
    +        if (options.browserify) {
    --- End diff --
    again, all of this switching is not required, nor passing the options.browserify property
around because plugman.prepare is already dynamic based on the options.
    IF (options.browserify) is TRUE
    THEN so is ( plugman.prepare === plugman.prepareBrowserify )

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message