cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From purplecabbage <...@git.apache.org>
Subject [GitHub] cordova-lib pull request: CB-7190: Add browserify support in cordo...
Date Tue, 29 Jul 2014 19:04:21 GMT
Github user purplecabbage commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/66#discussion_r15544876
  
    --- Diff: cordova-lib/src/plugman/plugman.js ---
    @@ -70,6 +70,7 @@ addProperty(plugman, 'install', './install', true);
     addProperty(plugman, 'uninstall', './uninstall', true);
     addProperty(plugman, 'fetch', './fetch', true);
     addProperty(plugman, 'prepare', './prepare');
    +addProperty(plugman, 'prepareBrowserify', './prepare-browserify');
    --- End diff --
    
    Isn't this already taken care of here:
    https://github.com/surajpindoria/cordova-lib/blob/browserify/cordova-lib/src/plugman/plugman.js#L131
    
    the browserify and non-browserify methods have the exact same signature, so we should
be calling a generic 'prepare' method which could be either one.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message