cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zalun <...@git.apache.org>
Subject [GitHub] cordova-plugin-file pull request: [FxOS] Support for resolve URI, ...
Date Fri, 25 Jul 2014 08:16:45 GMT
Github user zalun commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-file/pull/64#discussion_r15390363
  
    --- Diff: src/firefoxos/FileProxy.js ---
    @@ -54,6 +53,32 @@ QUIRKS:
         var DIR_SEPARATOR = '/';
         var DIR_OPEN_BOUND = String.fromCharCode(DIR_SEPARATOR.charCodeAt(0) + 1);
     
    +    var pathsPrefix = {
    +        // Read-only directory where the application is installed.
    +        applicationDirectory: location.origin + "/",
    +        // Root of app's private writable storage
    +        applicationStorageDirectory: null,
    +        // Where to put app-specific data files.
    +        dataDirectory: 'file:///persistent/',
    +        // Cached files that should survive app restarts.
    +        // Apps should not rely on the OS to delete files in here.
    +        cacheDirectory: 'file:///temporary/',
    +        // Android: the application space on external storage.
    +        externalApplicationStorageDirectory: null,
    +        // Android: Where to put app-specific data files on external storage.
    +        externalDataDirectory: null,
    +        // Android: the application cache on external storage.
    +        externalCacheDirectory: null,
    +        // Android: the external storage (SD card) root.
    +        externalRootDirectory: null,
    +        // iOS: Temp directory that the OS can clear at will.
    +        tempDirectory: null,
    +        // iOS: Holds app-specific files that should be synced (e.g. to iCloud).
    +        syncedDataDirectory: null,
    +        // iOS: Files private to the app, but that are meaningful to other applciations
(e.g. Office files)
    +        documentsDirectory: null
    +    };
    +
    --- End diff --
    
    I think they're not needed, also confusing for someone who'd read the source. There is
also no chance it's gonna be called in code... Please remove or if you think the message is
needed - comment out.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message