cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jkeshavarzi <...@git.apache.org>
Subject [GitHub] cordova-blackberry pull request: CB-7186 --no-signing will be igno...
Date Wed, 23 Jul 2014 18:08:50 GMT
Github user jkeshavarzi commented on a diff in the pull request:

    https://github.com/apache/cordova-blackberry/pull/169#discussion_r15304475
  
    --- Diff: bin/templates/project/cordova/lib/cmdline.js ---
    @@ -30,7 +30,8 @@ command
         .option('-p, --params <params JSON file>', 'Specifies additional parameters
to pass to downstream tools.')
         .option('--appdesc <filepath>', 'Optionally specifies the path to the bar descriptor
file (bar-descriptor.xml). For internal use only.')
         .option('-v, --verbose', 'Turn on verbose messages')
    -    .option('-l, --loglevel <loglevel>', 'set the logging level (error, warn, verbose)');
    +    .option('-l, --loglevel <loglevel>', 'set the logging level (error, warn, verbose)')
    +    .option('--signing', 'if signing the app');
    --- End diff --
    
    Ah, yes yes; You're right. We should still add some sort of note describing what the param
is used for though. Whether that's in the .option description or a comment in the code. Will
definitely be confusing to others.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message