cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jkeshavarzi <...@git.apache.org>
Subject [GitHub] cordova-blackberry pull request: Fixed issue: --buildId will disna...
Date Fri, 18 Jul 2014 14:39:08 GMT
Github user jkeshavarzi commented on a diff in the pull request:

    https://github.com/apache/cordova-blackberry/pull/169#discussion_r15114139
  
    --- Diff: bin/templates/project/cordova/lib/build.js ---
    @@ -81,10 +74,16 @@ try {
                         keystorepass = session.getKeyStorePass(command),
                         err;
     
    +                // buildId is specified
    +                if (command.buildId) {
    +                    bbwpArgv.push("--buildId");
    +                    bbwpArgv.push(command.buildId);
    +                }
                     if (command.release) {
    -                    copyArgIfExists("buildId");
                         if (command.signing) {
    -                        //Note: Packager refers to signing password as "password" not
"keystorepass"
    +                        bbwpArgv.push("--signing");
    --- End diff --
    
    Passing in just --signing should be enough to know you are signing. Don't need to specify
true/false. This cleans up the code as well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message