cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jkeshavarzi <...@git.apache.org>
Subject [GitHub] cordova-blackberry pull request: Fixed issue: --buildId will disna...
Date Fri, 18 Jul 2014 14:34:15 GMT
Github user jkeshavarzi commented on a diff in the pull request:

    https://github.com/apache/cordova-blackberry/pull/169#discussion_r15113856
  
    --- Diff: bin/templates/project/cordova/lib/build.js ---
    @@ -108,8 +110,15 @@ try {
                         bbwpArgv.push("-d");
                     }
     
    -                copyArgIfExists("params");
    --- End diff --
    
    Why not leave the copyArgIfExists function alone? It sets up the commands exactly as they
need to be set and avoids errors like this... The way this is coded the packager would puke
if passed params or loglevel.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message