cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From purplecabbage <...@git.apache.org>
Subject [GitHub] cordova-android pull request: Support for PluginFactory
Date Mon, 14 Jul 2014 19:39:28 GMT
Github user purplecabbage commented on the pull request:

    https://github.com/apache/cordova-android/pull/97#issuecomment-48949233
  
    I think this needs to be discussed more before merged, this seems to potentially break
stuff, and the benefit has not clearly been discussed. ( or alternatives ) 
    Essentially, Plugin creation code has been moved into it's own class ( cool ) ... which
then must be passed all over the place ... ( less cool )
    
    I would like to hear more about the specific problem this is attempting to solve, and
some discussion on potential other methods of solving it.
    
    Also, the fact that István clearly states 'I'm quite a newbie programmer ..' does not
give me great confidence, although the code looks good, I fear architectural pitfalls.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message