cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From agrieve <...@git.apache.org>
Subject [GitHub] cordova-ios pull request: Fixed RegEx error when callbackId is nil
Date Mon, 14 Jul 2014 19:25:21 GMT
Github user agrieve commented on a diff in the pull request:

    https://github.com/apache/cordova-ios/pull/97#discussion_r14897935
  
    --- Diff: CordovaLib/Classes/CDVCommandDelegateImpl.m ---
    @@ -107,6 +107,10 @@ - (BOOL)isValidCallbackId:(NSString *)callbackId
                 return NO;
             }
         }
    +    //Allow nil callbackId
    +    if (callbackId == nil){
    +      return YES;
    --- End diff --
    
    I think this should return NO. nil is not a valid callback id.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message