cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sriranggd <...@git.apache.org>
Subject [GitHub] cordova-lib pull request: CB-7118 iOS: add target-device and Minim...
Date Sat, 12 Jul 2014 22:39:09 GMT
Github user sriranggd commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/57#discussion_r14855708
  
    --- Diff: cordova-lib/src/cordova/metadata/ios_parser.js ---
    @@ -217,6 +220,38 @@ module.exports.prototype = {
                 self.update_overrides();
                 util.deleteSvnFolders(self.www_dir());
             });
    +    },
    +
    +    update_build_settings:function(config) {
    +        var targetDevice = parseTargetDevicePreference(config.getPreference('target-device',
'ios'));
    +        var deploymentTarget = config.getPreference('deployment-target', 'ios');
    +
    +        // no build settings provided, we don't need to parse and update .pbxproj file
    +        if (!targetDevice && !deploymentTarget) {
    +            return Q();
    +        }
    +
    +        var me = this;
    +        var d = Q.defer();
    +        var proj = new xcode.project(this.pbxproj);
    +        proj.parse(function(err,hash) {
    +            if (err) {
    +                d.reject(new Error('An error occured during parsing of project.pbxproj.
Start weeping. Output: ' + err));
    +                return;
    +            }
    +            var buildConfiguration = proj.pbxXCBuildConfigurationSection();
    +            if (targetDevice) {
    +                // TODO: replace propReplace with proj.updateBuildProperty after below
is release
    +                // https://github.com/alunny/node-xcode/pull/33
    --- End diff --
    
    Looks like your changes to xcode module were accepted and also released as version `0.6.7`.
I think it would be best to put in the new `updateBuildProperty` and get this merged, along
with an update to the `xcode` version in the dependency list.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message