cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jkeshavarzi <...@git.apache.org>
Subject [GitHub] cordova-lib pull request: CB-7067 run jasmine tests individually
Date Mon, 07 Jul 2014 15:05:04 GMT
Github user jkeshavarzi commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/51#discussion_r14601125
  
    --- Diff: cordova-lib/src/cordova/superspawn.js ---
    @@ -108,11 +108,17 @@ exports.spawn = function(cmd, args, opts) {
         if (child.stdout) {
             child.stdout.setEncoding('utf8');
             child.stdout.on('data', function(data) {
    +            if (opts && 'onstdout' in opts) {
    +                if (opts.onstdout(data)) { return; }
    +            }
                 capturedOut += data;
             });
     
             child.stderr.setEncoding('utf8');
             child.stderr.on('data', function(data) {
    +            if (opts && 'onstderr' in opts) {
    +                if (opts.onstdout(data)) { return; }
    --- End diff --
    
    Shouldn't this be `opts.onstderr(data)`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message