cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kamrik <...@git.apache.org>
Subject [GitHub] cordova-lib pull request: CB-7067 run jasmine tests individually
Date Thu, 03 Jul 2014 13:51:51 GMT
Github user kamrik commented on the pull request:

    https://github.com/apache/cordova-lib/pull/51#issuecomment-47931920
  
    I really like the results it produces!
    But I'm somewhat surprised by the amount of code. The diff with jasmine cli.js looks pretty
big, which probably means that much of the code _is_ new, or did it come from some place else?
    
    We should write a big comment first thing in that file, that it should be spun off as
an independent package soon.
    
    How does it go with license compatibility, can we incorporate MIT licensed files or parts
of files?
    
    The other option os to just publish it as an independent package right away.
    
    Here is an independent superspawn package [1], we may choose to depend on it or just bundle
the required version of superspawn.js file. 
    
    [1] https://www.npmjs.org/package/superspawn


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message