cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From agrieve <...@git.apache.org>
Subject [GitHub] cordova-plugin-splashscreen pull request: CB-3562 Disable screen r...
Date Wed, 02 Jul 2014 20:22:23 GMT
Github user agrieve commented on the pull request:

    https://github.com/apache/cordova-plugin-splashscreen/pull/14#issuecomment-47830696
  
    Ah, I gotcha, It's because the shouldAutorotate selector has no setter in CDVViewController.
    
    @shazron - any opinion on this? with swizzling it will work with existing cordova-ios,
but it would be easy to make a setter for shouldAutorotate settable, or alternatively make
supportedOrientations public. I'm leaning towards accepting this as-is since it works and
only swizzles a UIViewController selector.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message